[ready to merge] docs(chrome-extension): salvage useful bits from #588#643
Conversation
Pulls forward the small bits worth keeping from Eli's original Chrome Extension docs PR, since the page itself has evolved well past that draft via several subsequent merged PRs. - Add a frontmatter description so GitBook renders proper metadata - Add an inline pointer to the Submit and cancel pull requests reference page after the Submit steps, so readers can drill into the full lifecycle from this entry point - Replace the FAQ link to a hard-coded GitHub commit URL with a relative path to getting-started, matching the rest of the docs Closes the conflict-stale #588 in favor of these targeted edits on top of the current main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
😎 Merged successfully - details. |
|
Claude finished @samgutentag's task in 1m 17s —— View job Review: PR #643 — salvage useful bits from #588
SummaryClean, low-risk salvage PR. All three changes do what the description claims, and I don't see any blocking issues. What's good
Minor nit (non-blocking, posted inline on line 36)The first clause of the new sentence ("...same backend as the VerdictLGTM. Approving the spirit; flagging the inline nit for the author's call. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| 3. Optionally choose a [priority](optimizations/priority-merging.md) before submitting. | ||
| 4. If batching is enabled for the repository, you can toggle **Skip batching** to enqueue this PR without grouping it into a batch — useful for hotfixes or PRs that need to merge without waiting for a batch window. | ||
|
|
||
| Submission goes through the same backend as the `/trunk merge` comment and the Trunk web app, so behavior is identical. See [Submit and cancel pull requests](using-the-queue/reference.md) for the full lifecycle. |
There was a problem hiding this comment.
Nit, non-blocking: the first half of this sentence ("Submission goes through the same backend as the /trunk merge comment and the Trunk web app, so behavior is identical") overlaps closely with the FAQ entry below ("How does the extension differ from the /trunk merge comment?"), which says "Both go through the same Trunk Merge Queue backend." If you want to deduplicate, you could trim this to just the pointer — e.g., "See Submit and cancel pull requests for the full lifecycle." — and let the FAQ keep the equivalence claim. Up to you; either way is fine.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Verification status (2026-05-07): Verified: customers can use this. Ready to publish.
Ready to merge as soon as review is complete. |
samgutentag
changed the title
1 participant
Summary
Pulls forward the small bits worth keeping from #588 (Eli's original Chrome Extension docs PR), since the page itself has evolved well past that draft via several subsequent merged PRs (#593, #595, #598, #626, #639).
Changes
description:so GitBook renders proper page metadata for SEO and navigation previewsgetting-started/, matching the rest of the docsTest plan
using-the-queue/reference.mdresolves correctlygetting-started/resolves correctlyRelated